Installer for codegen ui #55
Conversation
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]> chores(ui): codegen ui Signed-off-by: ashutosh16 <[email protected]> chores(ui): codegen ui Signed-off-by: ashutosh16 <[email protected]> chores(ui): codegen ui Signed-off-by: ashutosh16 <[email protected]> chores(ui): codegen ui Signed-off-by: ashutosh16 <[email protected]> chores(ui): codegen ui Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Makefile
Outdated
| @@ -259,6 +259,15 @@ generate-mocks: mockery ## Generate the mocks for the project as configured in . | |||
| clean-ui: | |||
| find ${UI_DIR} -type f -name extension.tar -delete | |||
|
|
|||
| PHONY: codegen-download-openapi | |||
| codegen-download-openapi: run-backend | |||
There was a problem hiding this comment.
This doesn't work as it blocks during run-backend and never executes the yarn command below
There was a problem hiding this comment.
add the missing files; ran in local and able to generate the schema.yaml
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Makefile
Outdated
| @@ -259,8 +263,22 @@ generate-mocks: mockery ## Generate the mocks for the project as configured in . | |||
| clean-ui: | |||
| find ${UI_DIR} -type f -name extension.tar -delete | |||
|
|
|||
| .PHONY: codegen-download-openapi run-backend | |||
|
|
|||
| codegen-download-openapi: | |||
There was a problem hiding this comment.
please add build and goreman as a dependency of this target. Also add the documentation for the target.
Use this as a reference:
argocd-ephemeral-access/Makefile
Line 106 in d2735f1
Makefile
Outdated
| @@ -259,8 +263,22 @@ generate-mocks: mockery ## Generate the mocks for the project as configured in . | |||
| clean-ui: | |||
| find ${UI_DIR} -type f -name extension.tar -delete | |||
|
|
|||
| .PHONY: codegen-download-openapi run-backend | |||
|
|
|||
Makefile
Outdated
| @@ -259,8 +263,22 @@ generate-mocks: mockery ## Generate the mocks for the project as configured in . | |||
| clean-ui: | |||
| find ${UI_DIR} -type f -name extension.tar -delete | |||
|
|
|||
| .PHONY: codegen-download-openapi run-backend | |||
There was a problem hiding this comment.
pls fix the .PHONY statement. It should only contain the name of the target.
Ex:
.PHONY: codegen-download-openapi
Makefile
Outdated
| @@ -259,8 +263,22 @@ generate-mocks: mockery ## Generate the mocks for the project as configured in . | |||
| clean-ui: | |||
| find ${UI_DIR} -type f -name extension.tar -delete | |||
|
|
|||
| .PHONY: codegen-download-openapi run-backend | |||
|
|
|||
| codegen-download-openapi: build goreman | |||
There was a problem hiding this comment.
Pls add a brief description about what the target does
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Makefile
Outdated
| .PHONY: build-ui | ||
| build-ui: clean-ui | ||
| build-ui: clean-ui codegen-ui |
There was a problem hiding this comment.
build-ui can not depend on codegen-ui as orval would never be installed in this case
Signed-off-by: ashutosh16 <[email protected]>
No description provided.